Fix :start and :end json accesses on snowflake #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7633710337
💛 - Coveralls |
9 tasks
alamb
approved these changes
Jan 25, 2024
| @@ -229,6 +229,24 @@ fn parse_json_using_colon() { | |||
| ); | |||
|
|
|||
| snowflake().one_statement_parses_to("SELECT a:b::int FROM t", "SELECT CAST(a:b AS INT) FROM t"); | |||
|
|
|||
| let sql = "SELECT a:start, a:end FROM t"; | |||
There was a problem hiding this comment.
I looked for a few minutes and couldn't actually find any mention of this syntax in the documentation. 🤯 but I trust you it exists
There was a problem hiding this comment.
This is just the regular : operator for accessing a field within an OBJECT / VARIANT. start and end aren't special here, they're just field names that SF permits but we were failing to parse. Maybe it would have been clearer if I used SELECT a:start, a:end FROM (select parse_json('{"start":0,"end":1}') a) for the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.