Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for JSON_TABLE #1062

Merged
merged 1 commit into from
Dec 19, 2023
Merged

add support for JSON_TABLE #1062

merged 1 commit into from
Dec 19, 2023

Conversation

@coveralls
Copy link

coveralls commented Dec 4, 2023

Pull Request Test Coverage Report for Build 7091199686

  • 93 of 105 (88.57%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 87.71%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 44 47 93.62%
src/ast/query.rs 23 32 71.88%
Files with Coverage Reduction New Missed Lines %
src/ast/query.rs 1 83.08%
Totals Coverage Status
Change from base Build 7009122777: 0.004%
Covered Lines: 18085
Relevant Lines: 20619

💛 - Coveralls

@lovasoa
Copy link
Contributor Author

lovasoa commented Dec 4, 2023

@alamb : I'm adding more and more json-related features to SQLPage, and users are starting to complain about failed query parsing in MySQL. It would be great if we could get this merged :)

@alamb
Copy link
Contributor

alamb commented Dec 4, 2023

@alamb : I'm adding more and more json-related features to SQLPage, and users are starting to complain about failed query parsing in MySQL. It would be great if we could get this merged :)

Thanks @lovasoa -- I will try and review this in the next day or two

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @lovasoa

@alamb alamb merged commit f46f147 into apache:main Dec 19, 2023
10 checks passed
@lovasoa lovasoa deleted the json_table branch December 20, 2023 09:04
@lovasoa
Copy link
Contributor Author

lovasoa commented Dec 20, 2023

Thanks @alamb ! This will be very useful in sqlpage !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support MySQL's JSON_TABLE
3 participants