This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
fix(ios): Avoid infinite loop on cancelled navigation #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
Ref apache/cordova-ios#334
Platforms affected
iOS
Motivation and Context
Fixes #83
Description
Similar as the fix in apache/cordova-ios#334. It has the same symptoms.
The change is to not try to load the error URL in the event that didFailNavigation occurred in response to a cancelled navigation.
Testing
The issue seems to be timing related. I found that it did not always replicate, depending on the device, and which server we were connecting to. As such, it is hard to produce an exact set of steps. But I found that for the servers against which we were always seeing the issue (100% replication), it no longer occurred.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)