Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(ios): Avoid infinite loop on cancelled navigation #84

Closed
wants to merge 1 commit into from

Conversation

gwynjudd
Copy link

Fixes #83
Ref apache/cordova-ios#334

Platforms affected

iOS

Motivation and Context

Fixes #83

Description

Similar as the fix in apache/cordova-ios#334. It has the same symptoms.

The change is to not try to load the error URL in the event that didFailNavigation occurred in response to a cancelled navigation.

Testing

The issue seems to be timing related. I found that it did not always replicate, depending on the device, and which server we were connecting to. As such, it is hard to produce an exact set of steps. But I found that for the servers against which we were always seeing the issue (100% replication), it no longer occurred.

Checklist

  • [ x ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [ x ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

@sirlantj
Copy link

I have the same issue

@janpio janpio changed the title (iOS) - Avoid infinite loop on cancelled navigation fix(ios): Avoid infinite loop on cancelled navigation Jul 4, 2019
@jcesarmobile
Copy link
Member

We are archiving this repository following Apache Cordova's Deprecation Policy. We will not continue to work on this repository. Therefore all issues and pull requests are being closed. Thanks for your contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(iOS) Infinite Loop when a "NSURLErrorCancelled -999" is received on didFailLoadWithError
4 participants