GH-314: (iOS) Fix bug with removing temp UIWindow when browser exits. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobilestar2015
changed the title
|
Hi, did you try with current master before? I can't reproduce after this fix I sent I think I tried with your approach and wasn't working sometimes, so I ended up with my change. In any case, it shouldn't be on |
|
This was fixed by #336 |
|
Hey, I don't know what link of this PR, i can write in my package.json. Could you help me, please ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
Fixed a bug that the app is not responding after the inappbrowser controller closed.
What testing has been done on this change?
Tested on ionic 3 app.
Checklist