Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move CDVURLSchemeHandler to private API #1477

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Aug 24, 2024

Platforms affected

iOS

Motivation and Context

This is only used by the WKWebView plugin, and there's no way to do anything meaningful with it as public API, so it probably shouldn't be public API.

Description

Moved CDVURLSchemeHandler files out of the public API.

Testing

Existing tests pass.

Checklist

  • I've run the tests to see all new and existing tests pass

This is only used by the WKWebView plugin, and there's no way to do
anything meaningful with it as public API, so it probably shouldn't be
public API.
@dpogue dpogue added this to the 8.0.0 milestone Aug 24, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (e327997) to head (be2963a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1477   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files          16       16           
  Lines        1871     1871           
=======================================
  Hits         1501     1501           
  Misses        370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the Cordova sample app and an app with all Apache Cordova Plugins loaded..

The test also included setting the custom URL scheme.

@dpogue dpogue merged commit 8e59e52 into apache:master Aug 25, 2024
10 checks passed
@dpogue dpogue deleted the scheme-handler branch August 25, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants