Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update CDVAllowList to support more valid schemes #1473

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Aug 21, 2024

Platforms affected

iOS

Motivation and Context

These may be unusual schemes, but they are canonically valid and should be supported.

Closes GH-1291.

Description

Update the regex in CDVAllowList to the one @erisu suggested.

Testing

Added a test case to confirm the schemes are parsed properly.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

These may be unusual schemes, but they are canonically valid and should
be supported.

Closes apacheGH-1291.
@dpogue dpogue added this to the 8.0.0 milestone Aug 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (3ce3a7e) to head (4280651).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1473   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files          16       16           
  Lines        1871     1871           
=======================================
  Hits         1501     1501           
  Misses        370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpogue dpogue merged commit f3339a9 into apache:master Aug 21, 2024
10 checks passed
@dpogue dpogue deleted the allowlist-scheme branch August 21, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

one question about CDVAllowList
3 participants