Automatically register the codecs for CqlVectorType in CachingCodecRegistry #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Jun 12, 2023
msmygit
approved these changes
Jun 13, 2023
|
This is probably a useful idea for a future Java driver release but it is not required to add support for the vector type to dsbulk. See this PR for an example of how we can support the vector type in dsbulk using only a stock Java driver. |
|
@absurdfarce I need this patch for the Cassandra Sink and not DSBulk. |
|
for reference: |
|
This issue has been addressed by changes in #1666. If there's something else we need to consider please re-open and add a comment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.