GraalVM native image support fixes #1611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@delete is not supported (native build broken) on classes that have a field of their own type with GraalVM 22.2 and upcoming 22.3, and that's the case for Lz4Compressor which has a Lz4Compressor field. In practice, those @delete substitutions are useless because Lz4Compressor and SnappyCompressor won't be reachable after newInstance substitution has been applied, so this commit removes them.
The Dependency class is used in the various BooleanSupplier implementations for the class specified in the @TargetClass onlyWith annotation attribute. Without an explicit initialization of this class at build time, the native build is broken with a "Dependency was unintentionally initialized at build time error" message. This commit initializes the Dependency class at build time, which seems to be safe in terms of compatibility as it does not require transitively the initialization of other classes at build time.
|
Thanks for the PR @sdeleuze! Have you signed the Contributor License Agreement for contributions to DataStax open source projects? If not you can find it at https://cla.datastax.com/. Thanks! |
|
Not yet, I will see if I can sign it and let you know. |
|
Since I won't be able to have the CLA signed by my company is a reasonable amount of time and effort, I have turned this PR into the issue JAVA-3045 and kindly ask one of the committers of this project to commit the simple fixes proposed in the related issue (should match the changes of this PR, feel free to reuse the commit messages). |
|
Replaced with #1612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 blocking issues (native build broken) observed on https://github.com/spring-projects/spring-aot-smoke-tests/tree/main/data-cassandra which is used to validate the native support of Spring Boot 3. I have provided detailed explanation in the commit messages.
Tested with GraalVM 22.2 and upcoming GraalVM 22.3, but those changes should be fine with previous versions as well.