Avoid full cluster scans in Connection.checkClusterName

[haaawk]

Select without a partition key results in full cluster
scan that can hurt the performance of the cluster.
There is an easy solution to the problem by just
using a 'local' partition key for the query.

Signed-off-by: Piotr Jastrzebski piotr@scylladb.com

[olim7t]

SGTM
I don't think it will change anything about performance, at least with Apache Cassandra. But on the other hand it doesn't hurt either, is more correct from a theoretical standpoint, and we already do it for other system.local queries.

[haaawk]

Thank you - much appreciated.

[adutra]

@haaawk We realized that for some reason our CLA bot did not ask you to sign our CLA. Would you mind signing it for us here: https://cla.datastax.com/ ? If you do this today you might be able to get your contribution shipped with 3.7.0. Thanks!

[haaawk]

Hi @adutra I can't sign this unfortunately. Not because I don't want to but because I don't qualify. I'm not able to sign because of section 8. Would you have an agreement for companies? My employer could sign it to ensure the code stays free and open source.

@avikivity would be able to provide better information

[adutra]

I understand. I will check with our legal team and will get back to you when I have an answer. Unfortunately, in the meanwhile we'll have to revert your contribution, but hopefully once this legal problem is settled you will be able to contribute it again. Sorry.

[haaawk]

@adutra I understand and hope this can be resolved relatively easily. Sorry for the troubles.

[avikivity]

To be clear, we have no objections to @haaawk signing the CLA; it's just that it makes no provision for people contributing with the consent their employer.

[adutra]

According to our legal team: "Section 8 requires the author to make a representation that he owns the proposed contribution, and not his employer. If the author is unable to sign because his employer owns the proposed contribution (and thus the copyright), then we need his employer to sign a different CLA. If that's the case, please let me know the name of his employer and we will draft it for him."

[haaawk]

This is exactly the case @adutra. The name of my employer is ScyllaDB.

[gmatza]

@adutra Hello. I work with @haaawk. We'd like to get that CLA signed. Company name, officially, should be ScyllaDB, Ltd. Any legal docs or further discussion with your Legal can come through my email, 'greg at scylladb.com'

[adutra]

@gmatza as a matter of fact I just got word from our legal team. I will send the special CLA to the address you mentioned above. Thanks!

[haaawk]

@adutra my company has signed all the documents. Should we proceed with the change?

[adutra]

@haaawk not just yet :-) the ball is now in the hands of our legal team, the CLA needs to be signed by us as well before we are allowed to proceed. Stay tuned.

[haaawk]

@adutra I see. Sorry for jumping the gun.