DialHost must connect to the requested host #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurovenancio
changed the title
laurovenancio
force-pushed
the
fix-host-dial
branch
2 times, most recently
from
b85edda
to
5f78076
Compare
|
Hi, thank you for the pull request! The change looks good to me. Please also update AUTHORS.md as per CONTRIBUTING.md and we can merge this. |
When a hostname resolves to multiple hosts, multiple HostInfos are generated. DialHost must connect to the host received as parameter. If the hostname is used to establish the connection, the dns could resolve to another host. The hostname should still be used to verify the TLS connection.
laurovenancio
force-pushed
the
fix-host-dial
branch
from
de085a5
to
65fb7cb
Compare
@martin-sucha Rebased and authors updated. |
|
had a similar fix here #1670 to avoid IP address conflicts. Not sure if it's still necessary or not with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a hostname resolves to multiple hosts, multiple HostInfos are generated. DialHost must connect to the host received as parameter. If the hostname is used to establish the connection, the dns could resolve to another host.
The hostname should still be used to verify the TLS connection.