Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conn: fix race evicting statements on ErrUnPrepared #1391

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

Zariel
Copy link
Contributor

@Zariel Zariel commented Jan 15, 2020

Ensure we only remove prepared statements on ErrUnPrepared when our
cached statements ID matches the unprepared statement.

fixes #1390

Ensure we only remove prepared statements on ErrUnPrepared when our
cached statements ID matches the unprepared statement.
@alourie
Copy link
Contributor

alourie commented Jan 15, 2020

LGTM

@Zariel Zariel merged commit 617765a into apache:master Jan 15, 2020
@Zariel Zariel deleted the conn/dont-invalidate-prepared branch January 15, 2020 13:58
martin-sucha added a commit to kiwicom/gocql that referenced this pull request Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequestErrUnprepared should evict only the preparedStatement with old id
2 participants