[BEAM-3792] Allow manual specification of external address for ULR. #4811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @axelmagn |
|
LGTM once formatting issues are fixed |
axelmagn
added a commit
to axelmagn/beam
that referenced
this pull request
Mar 8, 2018
robertwb
added a commit
to robertwb/incubator-beam
that referenced
this pull request
Mar 9, 2018
Bugfix changes from apache#4811
axelmagn
added a commit
to axelmagn/beam
that referenced
this pull request
Mar 12, 2018
robertwb
pushed a commit
to robertwb/incubator-beam
that referenced
this pull request
Apr 13, 2018
|
Jenkins: retest this please. Error warning: no files found matching 'protoc_deps.py' seems unrelated. |
|
Jenkins: retest this please. |
2 similar comments
|
Jenkins: retest this please. |
|
Jenkins: retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION HERE
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.