Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle to use 3.12 for metrics report #32547

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Sep 24, 2024

We should also move this out of the jenkins folder, which is why this was missed.

Example run with the change - https://github.com/apache/beam/actions/runs/11018241174


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the infra label Sep 24, 2024
@damccorm damccorm changed the title Update build.gradle to use 3.12 Update build.gradle to use 3.12 for metrics report Sep 24, 2024
@damccorm damccorm marked this pull request as ready for review September 24, 2024 18:08
@damccorm
Copy link
Contributor Author

R: @jrmccluskey

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrmccluskey
Copy link
Contributor

Agreed, a deep-dive into the jenkins folder is needed to relocate what is still used and clear out what isn't

@damccorm damccorm merged commit 5d8b041 into master Sep 24, 2024
7 checks passed
@damccorm damccorm deleted the damccorm-patch-1 branch September 24, 2024 18:13
Naireen pushed a commit to Naireen/beam that referenced this pull request Sep 26, 2024
* Update build.gradle to use 3.12

* Take version from default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants