-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix examples on website #31066
fix examples on website #31066
Conversation
add DataflowRunner in wordCount run command with Gradle
Update dataflow.md to update mvn package and run commands
R: @liferoad |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
@@ -297,7 +297,7 @@ TODO: document Spark on Gradle: https://github.com/apache/beam/issues/21502 | |||
{{< runner dataflow >}} | |||
gradle clean execute -DmainClass=org.apache.beam.examples.WordCount \ | |||
--args="--project=<your-gcp-project> --inputFile=gs://apache-beam-samples/shakespeare/* \ | |||
--output=gs://<your-gcs-bucket>/counts" -Pdataflow-runner | |||
--output=gs://<your-gcs-bucket>/counts --runner=DataflowRunner" -Pdataflow-runner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need -Pdataflow-runner
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it is required, as otherwise it gives error "Exception in thread "main" java.lang.IllegalArgumentException: Unknown 'runner' specified 'DataflowRunner', supported pipeline runners [DirectRunner, PortableRunner, TestUniversalRunner]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @Abacn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. -Pdataflow-runner is a flag for maven pprofile. It adds beam-runners-google-cloud-dataflow-java to classpath; --runner=DayaflowRinner is a pipeline option.
Fixes issues #2 and #3 captured in 30992
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.