Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#30083][prism] Stabilize additional teststream cases. #31046

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

lostluck
Copy link
Contributor

While working on adding Processing Time handling, it came to light that there were some inconsistent cases WRT handling TestStream based pipelines, in particular when there were no impulses included.

This fix uses the existing watermark hold system to restrain execution until the test stream is ready, and reflect holds based on test stream watermark events properly before their execution.

This discovered flaky fail behavior due to how timers and data outputs were handled in bundle processing, also fixed in this PR.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits, thanks!

sdks/go/test/integration/primitives/teststream_test.go Outdated Show resolved Hide resolved
sdks/go/test/integration/primitives/teststream_test.go Outdated Show resolved Hide resolved
sdks/go/test/integration/primitives/teststream.go Outdated Show resolved Hide resolved
lostluck and others added 3 commits April 22, 2024 10:09
Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com>
Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com>
Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 54.39%. Comparing base (a26c505) to head (d17422e).
Report is 37 commits behind head on master.

Files Patch % Lines
...g/beam/runners/prism/internal/engine/teststream.go 91.42% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #31046      +/-   ##
==========================================
+ Coverage   54.33%   54.39%   +0.06%     
==========================================
  Files         307      307              
  Lines       38123    38174      +51     
==========================================
+ Hits        20713    20765      +52     
+ Misses      15781    15776       -5     
- Partials     1629     1633       +4     
Flag Coverage Δ
go 54.39% <94.82%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lostluck
Copy link
Contributor Author

Nice catches! Thanks. Merging once the recommits pass again.

@lostluck lostluck merged commit 8dcbf96 into apache:master Apr 22, 2024
7 checks passed
@lostluck lostluck deleted the teststreamRefit branch April 22, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants