-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add Vertex AI Feature Store enrichment notebook #30689
Conversation
R: @rszper |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this to the ReadMe? https://github.com/apache/beam/blob/master/examples/notebooks/beam-ml/README.md
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
Yeah, I think I can make a new list below the Data Preprocessing list and add both Bigtable and Vertex AI there. |
Thank you for the detailed review! Made the suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small edits, but otherwise LGTM
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb
Outdated
Show resolved
Hide resolved
…ipynb Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…ipynb Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
Made the changes, thanks! Merging. |
* add vertex ai enrichment notebook * address review comments, add to readme * Update examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com> * Update examples/notebooks/beam-ml/vertex_ai_feature_store_enrichment.ipynb Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com> * update content from review --------- Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
Notebook link
Add an example notebook to demonstrate enrichment transform with Vertex AI Feature Store handler.
Part of #30386
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.