Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Check feature store existence at construction time #30668

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

riteshghorse
Copy link
Contributor

Check existence of feature store for enrichment handler at construction time and raise an error irrespective of the exception_level.

Fixes #30386


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.
R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@damccorm
Copy link
Contributor

Oh, looks like postcommits are failing though, could you take a look please?

@damccorm
Copy link
Contributor

3.11 failure looks like an unrelated pubsub test

@damccorm
Copy link
Contributor

3.10 failure looks like an unrelated GameStatsIT failure. So this should be safe to move forward

@riteshghorse
Copy link
Contributor Author

riteshghorse commented Mar 19, 2024

Yeah looks like it, it is passing on master - https://github.com/apache/beam/actions/runs/8338077957/job/22817805661.

Thanks!

@riteshghorse riteshghorse merged commit 50f33cd into apache:master Mar 19, 2024
73 of 75 checks passed
hjtran pushed a commit to hjtran/beam that referenced this pull request Apr 4, 2024
…pache#30668)

* check feature store existence at construction time

* postcommit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Vertex AI Feature Store handler for Enrichment transform
2 participants