Github Workflow Replacement for Jenkins Jobs, beam_PerformanceTests_ManyFiles_TextIOIT* #28581
Conversation
| issue_comment: | ||
| types: [created] | ||
| schedule: | ||
| - cron: '10 2 * * *' |
There was a problem hiding this comment.
should be 10 2/12 * * * in accordance with the Jenkins pattern
There was a problem hiding this comment.
fixed 10 2/12 * * * every 12 hour (jenkins pattern)
| issue_comment: | ||
| types: [created] | ||
| schedule: | ||
| - cron: '50 2 * * *' |
There was a problem hiding this comment.
should be 50 2/12 * * * in accordance with the Jenkins pattern
There was a problem hiding this comment.
fixed 50 2/12 * * * every 12 hour (jenkins pattern)
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
There was a problem hiding this comment.
nit: please fix the formatting for all .txt files
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }} | ||
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }} | ||
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }} | ||
| beam_PerformanceTests_ManyFiles_TextIOIT_test_arguments_1: '' |
There was a problem hiding this comment.
What does putting this in here as an empty environment var do for us?
There was a problem hiding this comment.
Same question on the next job
There was a problem hiding this comment.
The intension was to avoid underlining the env variable in the workflow
There was a problem hiding this comment.
We will find a better solution on how to show how it's used in a workflow. Thank you for the comment!
PR migrates Jenkins Jobs to Github Actions Workflow:
".github/workflows/beam_PerformanceTests_ManyFiles_TextIOIT.yml"
".github/workflows/beam_PerformanceTests_ManyFiles_TextIOIT_HDFS.yml"
Jenkins Jobs:
https://ci-beam.apache.org/view/PerformanceTests/job/beam_PerformanceTests_ManyFiles_TextIOIT/
https://ci-beam.apache.org/view/PerformanceTests/job/beam_PerformanceTests_ManyFiles_TextIOIT_HDFS/
The code has been tested on Self-hosted GKE runners ubuntu 20.04.
Example runs:
beam_PerformanceTests_ManyFiles_TextIOIT.yml https://github.com/magicgoody/beam/actions/runs/6317825488
beam_PerformanceTests_ManyFiles_TextIOIT_HDFS.yml https://github.com/magicgoody/beam/actions/runs/6318155545
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.