-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Load Tests GBK Flink Batch Go workflow #28494
Add Load Tests GBK Flink Batch Go workflow #28494
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
-PloadTest.mainClass=group_by_key \ | ||
-Prunner=FlinkRunner \ | ||
'-PloadTest.args=${{ steps.set_configs.outputs.prepared_config_5 }}' \ | ||
- name: Teardown Flink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice that we can reuse ./.test-infra/dataproc/
scripts. Shall we wrap the interaction with dataproc to a composite action (that will automatically add teardown steps at the end)? CC: @damccorm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its kinda hard to do that cleanly with multiple gradle commands (its not super clear to me what we'd take in as inputs).
-PloadTest.mainClass=group_by_key \ | ||
-Prunner=FlinkRunner \ | ||
'-PloadTest.args=${{ steps.set_configs.outputs.prepared_config_5 }}' \ | ||
- name: Teardown Flink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its kinda hard to do that cleanly with multiple gradle commands (its not super clear to me what we'd take in as inputs).
-Prunner=FlinkRunner \ | ||
'-PloadTest.args=${{ steps.set_configs.outputs.prepared_config_5 }}' \ | ||
- name: Teardown Flink | ||
if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens in this script if this runs but the setup did not run? Does it just fail or are there side effects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will just fail with cluster NOT_FOUND error
--environment_type=DOCKER | ||
--environment_config=gcr.io/apache-beam-testing/beam-sdk/beam_go_sdk:latest | ||
--influx_db_name=beam_test_metrics | ||
--influx_hostname=http://10.128.0.96:8086 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as #28450 (comment) a load test builder step to set common options (e.g., currently if influxHost has changed then it needs to change all files)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
a68403a
to
bc3e799
Compare
Thanks. If I remember correctly this is one of the permared test. Could we migrate beam_LoadTests_Go_ParDo_Flink_Batch first which is known to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just left only one minor comment
beam_LoadTests_Go_GBK_Flink_Batch_test_arguments_1: '' | ||
beam_LoadTests_Go_GBK_Flink_Batch_test_arguments_2: '' | ||
beam_LoadTests_Go_GBK_Flink_Batch_test_arguments_3: '' | ||
beam_LoadTests_Go_GBK_Flink_Batch_test_arguments_4: '' | ||
beam_LoadTests_Go_GBK_Flink_Batch_test_arguments_5: '' | ||
beam_LoadTests_Go_GBK_Flink_Batch_test_arguments_6: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove these variables and leave a comment on line #107:
# The env variables are created and populated in the test-arguments-action as "<github.job>_test_arguments_<argument_file_paths_index>"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The following jenkins job has been migrated:
https://ci-beam.apache.org/job/beam_LoadTests_Go_GBK_Flink_Batch
https://ci-beam.apache.org/job/beam_LoadTests_Go_GBK_Flink_Batch_PR
How has it been tested?
The job has been tested on Self-hosted GKE runners ubuntu 20.04.
The following test cases are passed:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.