Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go SDK minimum Go version to 1.19 #25545

Merged
merged 4 commits into from
Feb 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/actions/setup-self-hosted-action/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ inputs:
required: false
description: 'Set as false if does not require java-8 setup'
default: 'true'
requires-go-18:
requires-go-19:
required: false
description: 'Set as false if does not require go-18 setup'
description: 'Set as false if does not require go-19 setup'
default: 'true'

runs:
Expand Down Expand Up @@ -64,7 +64,7 @@ runs:
distribution: 'temurin'
java-version: 8
- name: Set Go Version
if: ${{ inputs.requires-go-18 == 'true' }}
if: ${{ inputs.requires-go-19 == 'true' }}
uses: actions/setup-go@v3
with:
go-version: '1.18.0'
go-version: '1.19.0'
2 changes: 1 addition & 1 deletion .github/workflows/build_playground_frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
name: Build Playground Frontend App
runs-on: [self-hosted, ubuntu-20.04]
env:
GO_VERSION: 1.18.0
GO_VERSION: 1.19.6
BEAM_VERSION: 2.40.0
TERRAFORM_VERSION: 1.0.9
FLUTTER_VERSION: 3.3.2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/go_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
fetch-depth: 2
- uses: actions/setup-go@v3
with:
go-version: '1.18'
go-version: '1.19'
- name: Delete old coverage
run: "cd sdks/go/pkg && rm -rf .coverage || :"
- name: Run coverage
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/playground_deploy_backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
name: Build Playground Backend App
runs-on: ubuntu-latest
env:
GO_VERSION: 1.18.0
GO_VERSION: 1.19.6
BEAM_VERSION: 2.40.0
TERRAFORM_VERSION: 1.0.9
STAND_SUFFIX: ''
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ jobs:
- name: Install go
uses: actions/setup-go@v3
with:
go-version: '1.18'
go-version: '1.19'
- name: Download source from artifacts
uses: actions/download-artifact@v3
with:
Expand Down
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
* Add `WatchFilePattern` transform, which can be used as a side input to the RunInference PTransfrom to watch for model updates using a file pattern. ([#24042](https://github.com/apache/beam/issues/24042))
* Add support for loading TorchScript models with `PytorchModelHandler`. The TorchScript model path can be
passed to PytorchModelHandler using `torch_script_model_path=<path_to_model>`. ([#25321](https://github.com/apache/beam/pull/25321))
* The Go SDK now requires Go 1.19 to build. ([#25545](https://github.com/apache/beam/pull/25545))

## Breaking Changes

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2015,7 +2015,7 @@ class BeamModulePlugin implements Plugin<Project> {
def goRootDir = "${project.rootDir}/sdks/go"

// This sets the whole project Go version.
project.ext.goVersion = "go1.19.3"
project.ext.goVersion = "go1.19.6"

// Minor TODO: Figure out if we can pull out the GOCMD env variable after goPrepare script
// completion, and avoid this GOBIN substitution.
Expand Down
2 changes: 1 addition & 1 deletion dev-support/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ RUN pip3 install distlib==0.3.1 yapf==0.29.0 pytest
###
# Install Go
###
ENV DOWNLOAD_GO_VERSION=1.17.6
ENV DOWNLOAD_GO_VERSION=1.19.6
RUN wget https://golang.org/dl/go${DOWNLOAD_GO_VERSION}.linux-amd64.tar.gz && \
tar -C /usr/local -xzf go${DOWNLOAD_GO_VERSION}.linux-amd64.tar.gz
ENV GOROOT /usr/local/go
Expand Down
2 changes: 1 addition & 1 deletion sdks/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
// directory.
module github.com/apache/beam/sdks/v2

go 1.18
go 1.19

require (
cloud.google.com/go/bigquery v1.45.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import (

"github.com/apache/beam/sdks/v2/go/pkg/beam/core/graph/coder"
fnpb "github.com/apache/beam/sdks/v2/go/pkg/beam/model/fnexecution_v1"
"github.com/apache/beam/sdks/v2/go/pkg/beam/model/pipeline_v1"
pipepb "github.com/apache/beam/sdks/v2/go/pkg/beam/model/pipeline_v1"
"github.com/google/go-cmp/cmp"
"google.golang.org/protobuf/proto"
Expand Down Expand Up @@ -73,7 +72,7 @@ func Test_metricsStore_ContributeMetrics(t *testing.T) {
// TODO convert input to non-legacy metrics once we support, and then delete these.
input [][]*pipepb.MonitoringInfo

want []*pipeline_v1.MonitoringInfo
want []*pipepb.MonitoringInfo
}{
{
name: "int64Sum",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ The Python SDK supports Python 3.7, 3.8, 3.9, and 3.10.
{{< /paragraph >}}

{{< paragraph class="language-go">}}
The Go SDK supports Go v1.18+. SDK release 2.32.0 is the last experimental version.
The Go SDK supports Go v1.19+. SDK release 2.32.0 is the last experimental version.
{{< /paragraph >}}

{{< paragraph class="language-typescript">}}
Expand Down
2 changes: 1 addition & 1 deletion website/www/site/content/en/get-started/quickstart-go.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ If you're interested in contributing to the Apache Beam Go codebase, see the [Co

## Set up your environment

The Beam SDK for Go requires `go` version 1.18 or newer. It can be downloaded [here](https://golang.org/). Check that you have version 1.18 by running:
The Beam SDK for Go requires `go` version 1.19 or newer. It can be downloaded [here](https://golang.org/). Check that you have version 1.19 by running:

{{< highlight >}}
$ go version
Expand Down