Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception when requested error tag does not exist (#22401) #22405

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

bvolpato
Copy link
Contributor

@bvolpato bvolpato commented Jul 21, 2022

After 2.40.0 (this PR #17423), there are three to get the failed inserts from a BigQueryIO Write, as it was now added a specific tag/PCollection when using the write method via Storage API (STORAGE_WRITE_API or STORAGE_API_AT_LEAST_ONCE).

The exception when the requested tag is null is misleading now, as it explicitly says that the other method should be used. However, in the case of Storage API, the recommended method won't work either.

Closes #22401


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@bvolpato
Copy link
Contributor Author

R: @reuvenlax

Do you think the generic message "use a or b" is enough? Just to avoid giving a wrong recommendation.
I thought about explicitly checking what PCollection is available, but that may be too much.

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@johnjcasey
Copy link
Contributor

Thanks for finding this and adding improved logs. This LGTM, please LMK if there is any reason to hold off on merging, otherwise I'll merge this in tomorrow

@bvolpato
Copy link
Contributor Author

@johnjcasey Yes, this can be merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: BigQueryIO getFailedInserts fails when using Storage APIs
2 participants