-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FlatMap numpy array bug #22006
Fix FlatMap numpy array bug #22006
Conversation
R: @tvalentyn @robertwb |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #22006 +/- ##
==========================================
- Coverage 74.12% 73.97% -0.15%
==========================================
Files 702 702
Lines 93667 92850 -817
==========================================
- Hits 69431 68689 -742
+ Misses 22981 22906 -75
Partials 1255 1255
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
LGTM! I suppose you can merge or wait for other reviewers but fix makes sense to me. |
Thanks, I'm fine merging with your LGTM |
Fixes #22000
0de9821 introduced a regression when a FlatMap produced an instance of an iterable type that raises an error in
__bool__
, like numpy arrays. The regression was just caused by a trivial cleanup, which is reverted here.GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.