Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PeriodicImpulse generates unbounded PCollection #21815

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jun 11, 2022

Fixes #21606.

  • DoFn generates unbounded pcoll if marked by unbounded_per_element

  • Mark ImpulseSeqGenDoFn.process as unbounded_per_element

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

* DoFn generates unbounded pcoll if marked by unbounded_per_element

* Mark ImpulseSeqGenDoFn.process as unbounded_per_element
@Abacn Abacn marked this pull request as ready for review June 11, 2022 18:18
@Abacn
Copy link
Contributor Author

Abacn commented Jun 13, 2022

R: @lostluck

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I am not a python expert. That's @robertwb. I'll merge in tomorrow unless Robert chime's in first.

@lostluck lostluck merged commit a2c3ae6 into apache:master Jun 14, 2022
@Abacn Abacn deleted the pyperiodicFnUnbounded branch June 14, 2022 16:48
bullet03 pushed a commit to akvelon/beam that referenced this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python sdk's PeriodicImpulse generates a bounded PCollection
2 participants