-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite triggers and unit tests for Go SDK #21756
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #21756 +/- ##
==========================================
+ Coverage 74.00% 74.05% +0.04%
==========================================
Files 698 697 -1
Lines 92224 92119 -105
==========================================
- Hits 68253 68219 -34
+ Misses 22720 22645 -75
- Partials 1251 1255 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Run GoPortable PostCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @lostluck for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run Go Flink ValidatesRunner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the tests were enabled for flink but the validates runner for flink wasn't run.
Hmmm we could probably put the code phrase for each runner right near their filter lists to help folks learn what the code phrases are.
One test failed. I thought flink didn't support ProcessingTime triggers?
|
Flink doesn't support advancing processing time. That's the reason after processing time trigger is skipped. |
Run Go Flink ValidatesRunner |
3 similar comments
Run Go Flink ValidatesRunner |
Run Go Flink ValidatesRunner |
Run Go Flink ValidatesRunner |
I did a bit of manual handling to trigger flink, and verified the new tests exist. Merging! https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink_PR/145/ which passed. |
Closes #21759
Adds composite triggers. Tested on flink runner.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.