convert windmill min timestamp to beam min timestamp

[Naireen]

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.

[asf-ci]

Can one of the admins verify this patch?

[asf-ci]

Can one of the admins verify this patch?

[Naireen]

R: @scwhittle

[Naireen]

Run Java PreCommit

[scwhittle]

Run Java PreCommit

[scwhittle]

Test failure appeared unrelated BQ rate limiting, triggering rerun

@kennknowles as a possible merger

[aaltay]

Run Java PreCommit

[aaltay]

Run Java PreCommit

[kennknowles]

Run Java PreCommit

[aaltay]

Run Java PreCommit

[aaltay]

@kennknowles - precommit flaked 5 times in a row. We need to do something about it.

[kennknowles]

Yes. We have someone already working on "org.apache.beam.sdk.io.pulsar.PulsarIOTest.testReadFromSimpleTopic: Trying to claim offset 1655305408194 while last attempted was 1655305409570" but I think it just needs to be disabled. I also saw a lot of docker issues. Tests that use a local server in a docker container should probably be moved off of the main job. Because the job uses gradle's buildDependents it is hard to make fine-grained adjustments. I'm thinking about it.

[aaltay]

Yes. We have someone already working on "org.apache.beam.sdk.io.pulsar.PulsarIOTest.testReadFromSimpleTopic: Trying to claim offset 1655305408194 while last attempted was 1655305409570" but I think it just needs to be disabled. I also saw a lot of docker issues. Tests that use a local server in a docker container should probably be moved off of the main job. Because the job uses gradle's buildDependents it is hard to make fine-grained adjustments. I'm thinking about it.

Thank you.

I think I saw other issues as well. But I did not save the jenkins links. IO was the general root cause.

[kennknowles]

Hmm this is green but in https://ci-beam.apache.org/view/PostCommit/job/beam_PreCommit_Java_Cron/5560/ and all subsequent tests (including current PRs) we are seeing org.apache.beam.runners.dataflow.worker.WindmillTimerInternalsTest.testTimerDataToFromTimer fail with

Expected: <TimerData{timerId=0:-9223372036854775, timerFamilyId=, namespace=Global, timestamp=-290308-12-21T19:59:05.225Z, outputTimestamp=-290308-12-21T19:59:05.224Z, domain=EVENT_TIME, deleted=false}>
     but: was <TimerData{timerId=0:-9223372036854775, timerFamilyId=, namespace=Global, timestamp=-290308-12-21T19:59:05.225Z, outputTimestamp=-290308-12-21T19:59:05.225Z, domain=EVENT_TIME, deleted=false}>

and based on timing and code touched this PR seems the most likely to be related. TBH I don't get it since this seems like it is deterministic and would have been red on this PR

[Abacn]

"timestamp=-290308-12-21T19:59:05.225Z" is a negative year. It is an overflow. Looks like the conversion treated overflow integers in different way.

[Abacn]

This condition prevented timestamp overflow and broke unit test WindmillTimerInternalsTest.testTimerDataToFromTimer(=BoundedWindow.TIMESTAMP_MIN_VALUE). If this is intended behavior, should adjust the test case.