-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-14557] Read and Seek Runner Capabilities in Go SDK #17821
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
R: @lostluck |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #17821 +/- ##
=======================================
Coverage 74.09% 74.09%
=======================================
Files 697 697
Lines 91986 92068 +82
=======================================
+ Hits 68154 68216 +62
- Misses 22583 22601 +18
- Partials 1249 1251 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! LGTM
Run Go PostCommit |
Okay, it looks like the universal runner extracts metrics from MonitoringInfos for producing the pipeline result. Need to change that as well. |
The portable and flink runners are not requesting |
As discussed, we can't remove the monitoring infos due to other runners, but I have found the correct URNs we need to look out for and probably provide as a capability: "beam:protocol:monitoring_info_short_ids:v1" beam/model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto Line 1639 in 04f4984
|
Since the scope of the PR has changed, could the Title and PR Description be updated accordingly? |
retest this please |
https://ci-beam.apache.org/job/beam_PostCommit_Go_PR/438/ passed! Merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #21807
This PR provides parity with Java and Python SDK to read the runner capabilities and use it to optimize/support additional features/utilities. This PR focuses on supporting monitoring info with short ID.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.