-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10976] Fix bug with bundle finalization on SDFs (and a small doc bug) #17811
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Run Website_Stage_GCS PreCommit |
Codecov Report
@@ Coverage Diff @@
## master #17811 +/- ##
=======================================
Coverage 74.07% 74.07%
=======================================
Files 697 697
Lines 91927 91986 +59
=======================================
+ Hits 68091 68142 +51
- Misses 22591 22595 +4
- Partials 1245 1249 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Assigning reviewers. If you would like to opt out of this review, comment R: @youngoli for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Right now, running an SDF with a BundleFinalizer blows up with errors:
panic: runtime error: invalid memory address or nil pointer dereference goroutine 100
. It was working fine on non-SDFs.I was able to repro - failing pipeline:
And after the fix the same pipeline succeeds:
I also verified that non-SDFs still don't have any issues
This also fixes a doc bug with the programming guide which had the parameters misordered: ✨ RENDERED ✨
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.