Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-14532] Add integration testing to fhirio Read transform #17803

Merged
merged 14 commits into from
Jun 13, 2022
Merged

[BEAM-14532] Add integration testing to fhirio Read transform #17803

merged 14 commits into from
Jun 13, 2022

Conversation

lnogueir
Copy link
Contributor

@lnogueir lnogueir commented Jun 1, 2022 •
edited
Loading

Follow up to apache#17748.
Adds integration tests to the Read transform in fhirio package.

Fixes #21679

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Jun 1, 2022

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented Jun 1, 2022

Can one of the admins verify this patch?

@lnogueir
Copy link
Contributor Author

lnogueir commented Jun 1, 2022 •
edited
Loading

The 3 test files I added in sdks/go/data/fhir_bundles already exist in this repository under sdks/java/io/google-cloud-platform/src/test/resources/BUNDLE_PARSE_TEST. Is there any location for test files to be shared between the SDKs? That way we don't have to duplicate them.

@lnogueir
Copy link
Contributor Author

lnogueir commented Jun 1, 2022

R: @msbukal

@lnogueir
Copy link
Contributor Author

lnogueir commented Jun 1, 2022

R: @youngoli

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Jun 1, 2022 •
edited
Loading

Codecov Report

Merging #17803 (ed66c25) into master (f131b2d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #17803   +/-   ##
=======================================
  Coverage   74.02%   74.02%           
=======================================
  Files         698      698           
  Lines       92203    92203           
=======================================
  Hits        68256    68256           
  Misses      22696    22696           
  Partials     1251     1251
Flag Coverage Δ
go 50.93% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/io/fhirio/common.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f131b2d...ed66c25. Read the comment docs.

msbukal
msbukal approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@msbukal msbukal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beyond style nits.

sdks/go/pkg/beam/io/fhirio/read_test.go Outdated Show resolved Hide resolved
sdks/go/test/integration/io/fhirio/fhirio.go Outdated Show resolved Hide resolved
@lnogueir
Copy link
Contributor Author

lnogueir commented Jun 3, 2022

R: @youngoli

@lnogueir lnogueir mentioned this pull request Jun 6, 2022
Closed
@youngoli
Copy link
Contributor

youngoli commented Jun 9, 2022 •
edited
Loading

Run XVR_GoUsingJava_Dataflow PostCommit
Edit: Wrong test suite, ignore the results of this

@youngoli
Copy link
Contributor

youngoli commented Jun 9, 2022

Run Go Postcommit

@lnogueir lnogueir requested a review from youngoli June 9, 2022 20:51
youngoli
youngoli approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@youngoli youngoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@youngoli youngoli merged commit ca27853 into apache:master Jun 13, 2022
bullet03 pushed a commit to akvelon/beam that referenced this pull request Jun 20, 2022
@lnogueir @bullet03
[BEAM-14532] Add integration testing to fhirio Read transform (apache…
bee20da 
…#17803)

* add integration tests

* adjust import order to follow convention

* fixes to follow beam integration testing convention

* remove unused function and rename back to fakes_test.go

* import needed flags and read them properly

* unnest code in test

* add filters for specific runners

* add missing license

* rename member variable and use constant

* use better test files

* use gcpopts instead of pipeline options

* move testing logic to _test file

* filter direct runner as well since it doesnt provide the flags needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngoli youngoli youngoli approved these changes

@msbukal msbukal msbukal approved these changes

Assignees
No one assigned
Labels
go io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration test for Go FhirIO Read transform
4 participants
@lnogueir @asf-ci @youngoli @msbukal