[BEAM-14539] Ensure that the print stream can handle larger byte arrays being written and also allow for a growable amount of carry over. #17787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys being written and also allow for a growable amount of carry over.
|
R: @scwhittle Note that we never looped during decoding which lead to us copying the remainder of bytes over. |
scwhittle
reviewed
Jun 1, 2022
| @@ -65,8 +65,7 @@ private static class JulHandlerPrintStream extends PrintStream { | |||
| private final Level messageLevel; | |||
| private final CharsetDecoder decoder; | |||
There was a problem hiding this comment.
would it be good to add annotations that these are guarded?
| @@ -130,46 +128,50 @@ public synchronized void write(int i) { | |||
| @Override | |||
| public void write(byte[] a, int offset, int length) { | |||
| ByteBuffer incoming = ByteBuffer.wrap(a, offset, length); | |||
| assert incoming.hasArray(); | |||
There was a problem hiding this comment.
could return early for length == 0, not obvious if this would hold in that case
There was a problem hiding this comment.
it still does hold, added code to return early for length == 0
| for (LogRecord logRecord : handler.getLogs()) { | ||
| actualMessages.append(logRecord.getMessage()); | ||
| } | ||
| assertThat(actualMessages.toString(), containsString(msg + newlineMsg)); |
There was a problem hiding this comment.
nit: could this be equals instead of containsString?
There was a problem hiding this comment.
done, had to expose output warning since that is the prefix.
|
Otherwise LGTM |
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.