Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-11105] Add more watermark estimation docs for go #17785

Merged

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented May 31, 2022

There was some missing information about using watermark estimation (and restriction trackers), this fixes that oversight

RENDERED


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 31, 2022

Can one of the admins verify this patch?

4 similar comments
@asf-ci
Copy link

asf-ci commented May 31, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 31, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 31, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 31, 2022

Can one of the admins verify this patch?

@damccorm
Copy link
Contributor Author

R: @jrmccluskey @riteshghorse

@damccorm
Copy link
Contributor Author

damccorm commented Jun 1, 2022

R: @lostluck

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck merged commit d63c42b into apache:master Jun 2, 2022
@damccorm damccorm deleted the users/damccorm/watermarkEstimationDocs branch June 2, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants