Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-11106] documentation for SDF truncation in Go #17781

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

riteshghorse
Copy link
Contributor

Documentation for SDF truncation during drain added in #17432


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 31, 2022

Can one of the admins verify this patch?

4 similar comments
@asf-ci
Copy link

asf-ci commented May 31, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 31, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 31, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 31, 2022

Can one of the admins verify this patch?

@riteshghorse riteshghorse marked this pull request as draft May 31, 2022 14:42
@riteshghorse riteshghorse changed the title documentation for sdf truncation [BEAM-11106] documentation for SDF truncation in Go May 31, 2022
@riteshghorse riteshghorse marked this pull request as ready for review June 2, 2022 15:30
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@lostluck lostluck merged commit 937e22f into apache:master Jun 2, 2022
@riteshghorse riteshghorse deleted the drain-doc branch December 14, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants