-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Beam-14528]: Add ISO time format support for Timestamp, Date, DateTime, Time field. #17778
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
R: @chamikaramj |
R: @reuvenlax |
} catch (DateTimeParseException e) { | ||
return ChronoUnit.MICROS.between( | ||
// "12345667" | ||
ChronoUnit.MICROS.between( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the formatted datetime would be the more-common case, right? If so, then we should probably try to parse using the DateTimeFormatter first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I thought long is more common.
Run Java PostCommit |
Run Java PreCommit |
Please fix unit-test failures - they look related. |
PTAL, I double checked backend implementation, and found two things:
|
please run ./gradlew spotlessApply to fix spotless errors |
sorry, done. |
Run Java PreCommit |
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
There is a CheckStyle warning to fix - https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/5200/checkstyle/ |
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
With this fix, we should be able to accept:
Timestamp
"12345"
“2022-05-09T18:04:59Z” UTC
“2022-05-09T18:04:59.739-07:00”
“2022-05-09 18:04:59” UTC
Datetime
“2022-05-09T18:04:59”
“2022-05-09 18:04:59”
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.