Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14510] adding exception tests to LocalFileSystem #17753

Merged
merged 5 commits into from
Jun 1, 2022

Conversation

ahmedabu98
Copy link
Contributor

LocalFileSystem lacks some exception testing. This PR aims to fill that gap.

@asf-ci
Copy link

asf-ci commented May 25, 2022

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented May 25, 2022

Can one of the admins verify this patch?

@github-actions github-actions bot added the java label May 25, 2022
@github-actions github-actions bot added the build label May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #17753 (f71f458) into master (1dfab62) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17753      +/-   ##
==========================================
+ Coverage   73.98%   74.18%   +0.19%     
==========================================
  Files         696      696              
  Lines       91851    92655     +804     
==========================================
+ Hits        67958    68734     +776     
- Misses      22644    22672      +28     
  Partials     1249     1249              
Flag Coverage Δ
python 83.88% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/ml/inference/api.py 86.36% <0.00%> (-3.64%) ⬇️
.../apache_beam/runners/interactive/dataproc/types.py 97.61% <0.00%> (-2.39%) ⬇️
...s/interactive/dataproc/dataproc_cluster_manager.py 81.98% <0.00%> (-2.23%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
sdks/python/apache_beam/io/gcp/bigquery.py 64.96% <0.00%> (-0.15%) ⬇️
...ks/python/apache_beam/runners/worker/operations.py 74.02% <0.00%> (-0.07%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.30% <0.00%> (-0.01%) ⬇️
sdks/python/apache_beam/io/textio.py 96.89% <0.00%> (ø)
sdks/python/apache_beam/ml/inference/pytorch.py 0.00% <0.00%> (ø)
...s/python/apache_beam/io/gcp/pubsublite/external.py 0.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dfab62...f71f458. Read the comment docs.

@ahmedabu98
Copy link
Contributor Author

R: @johnjcasey, @pabloem, @chamikaramj

@pabloem
Copy link
Member

pabloem commented May 31, 2022

Run Python PreCommit

@johnjcasey
Copy link
Contributor

LGTM

@pabloem
Copy link
Member

pabloem commented Jun 1, 2022

Run Python PreCommit

@pabloem pabloem merged commit 55b378d into apache:master Jun 1, 2022
@ahmedabu98 ahmedabu98 deleted the localfilesystem_exceptions branch June 2, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants