[BEAM-14504] Add support for including addittional parameters to executebundle method in fhirio. #17741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
macksclark
reviewed
May 24, 2022
...oud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleWithMetadata.java
Outdated
Show resolved
Hide resolved
...oud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleWithMetadata.java
Outdated
Show resolved
Hide resolved
...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
Outdated
Show resolved
Hide resolved
...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
Outdated
Show resolved
Hide resolved
...atform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/GetStringHealthcareIOErrorFn.java
Outdated
Show resolved
Hide resolved
...atform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/GetStringHealthcareIOErrorFn.java
Outdated
Show resolved
Hide resolved
|
R: @msbukal |
msbukal
suggested changes
May 25, 2022
...oud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleWithMetadata.java
Outdated
Show resolved
Hide resolved
...oud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleWithMetadata.java
Outdated
Show resolved
Hide resolved
...oud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleWithMetadata.java
Outdated
Show resolved
Hide resolved
...oud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleWithMetadata.java
Outdated
Show resolved
Hide resolved
...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
Show resolved
Hide resolved
...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
Show resolved
Hide resolved
...atform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/GetStringHealthcareIOErrorFn.java
Outdated
Show resolved
Hide resolved
|
Run Java PostCommit |
|
Run Java PreCommit |
msbukal
suggested changes
May 27, 2022
...e-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleResponse.java
Outdated
Show resolved
Hide resolved
...e-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleResponse.java
Outdated
Show resolved
Hide resolved
...e-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleResponse.java
Outdated
Show resolved
Hide resolved
...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
Outdated
Show resolved
Hide resolved
...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
Outdated
Show resolved
Hide resolved
...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
Show resolved
Hide resolved
...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
Outdated
Show resolved
Hide resolved
...google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIOWriteIT.java
Show resolved
Hide resolved
|
Run Java PostCommit |
|
Run Java PostCommit |
|
Run Java PostCommit |
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
|
R: @pabloem |
pabloem
reviewed
May 31, 2022
...d-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleParameterCoder.java
Outdated
Show resolved
Hide resolved
...ud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleResponseCoder.java
Outdated
Show resolved
Hide resolved
|
Run Java PostCommit |
|
Run Java PreCommit |
2 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Run Java PreCommit |
2 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
issue unrelated. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Add FhirBundleWithMetadata in executebundles method so that we can pass additional information like message id.
FhirBundleWithMetadata represents a FHIR bundle, with it's metadata (eg. Hl7 messageId) to be executed on the intermediate FHIR store.
Make FhirResourcePagesIterator constructor public. Whistle plugins calls this constructor.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.