Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13982] Added output of logging for python E2E pytests #17637

Merged
merged 2 commits into from
May 16, 2022

Conversation

ryanthompson591
Copy link
Contributor

@ryanthompson591 ryanthompson591 commented May 12, 2022

Adds two options to output logs for python E2E tests.

log_cli=true -- Logs all logging messages to the command line (or jenkin's captures when run on jenkins)
log_level=INFO -- Sets log level to info and above.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@ryanthompson591
Copy link
Contributor Author

R: @tvalentyn

@asf-ci
Copy link

asf-ci commented May 12, 2022

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #17637 (3e82cfd) into master (f30e4e5) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #17637   +/-   ##
=======================================
  Coverage   73.95%   73.95%           
=======================================
  Files         693      693           
  Lines       91720    91721    +1     
=======================================
+ Hits        67832    67835    +3     
+ Misses      22639    22637    -2     
  Partials     1249     1249           
Flag Coverage Δ
python 83.71% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...ache_beam/runners/dataflow/test_dataflow_runner.py 29.62% <0.00%> (-3.03%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 89.20% <0.00%> (-1.44%) ⬇️
setup.py 0.00% <0.00%> (ø)
...hon/apache_beam/runners/worker/bundle_processor.py 93.68% <0.00%> (ø)
...on/apache_beam/runners/dataflow/dataflow_runner.py 83.00% <0.00%> (+0.04%) ⬆️
sdks/python/apache_beam/io/gcp/bigquery.py 63.98% <0.00%> (+0.11%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.09% <0.00%> (+0.15%) ⬆️
sdks/python/apache_beam/io/source_test_utils.py 89.40% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30e4e5...3e82cfd. Read the comment docs.

@tvalentyn
Copy link
Contributor

Run RAT PreCommit

@tvalentyn
Copy link
Contributor

Run Python 3.8 PostCommit

1 similar comment
@tvalentyn
Copy link
Contributor

Run Python 3.8 PostCommit

@ryanthompson591
Copy link
Contributor Author

AFAICT the postcommit runtime errors have anything to do with this PR.

@tvalentyn tvalentyn merged commit e6aab06 into apache:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants