Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13666] Stuck inventory jobs should be cancelled and rescheduled for next run #17582

Merged
merged 1 commit into from
May 9, 2022
Merged

[BEAM-13666] Stuck inventory jobs should be cancelled and rescheduled for next run #17582

merged 1 commit into from
May 9, 2022

Conversation

elink21
Copy link
Contributor

@elink21 elink21 commented May 6, 2022

As Valentyn mentioned on the Jira Ticket, if a worker is marked as temporarily offline and an Inventory job started during that process, then the job is going to stuck and it's necessary to cancel it manually and run it again later, even if the worker is back online it can not retake the job.

The reason behind that was the eligibility option set in the code, Eligibility options , by changing it to all nodes the job will continue it's execution after the worker is online again.

This change doesn't affect the stablished workers-job mapping, as the allowed nodes and default node options are already set.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 6, 2022

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented May 6, 2022

Can one of the admins verify this patch?

@github-actions github-actions bot added the infra label May 6, 2022
@tvalentyn
Copy link
Contributor

Thank you!

@tvalentyn tvalentyn merged commit c9883b2 into apache:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants