Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14410] Add test to demonstrate BEAM-14410 issue in non-cython environments #17548

Merged
merged 2 commits into from
May 31, 2022

Conversation

TheNeuralBit
Copy link
Member

Reproduce issue discovered in #17384, verify that it afffects master branch and not just that PR.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the python label May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #17548 (2edc6d3) into master (d5df315) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2edc6d3 differs from pull request most recent head 0005316. Consider uploading reports for the commit 0005316 to get more accurate results

@@            Coverage Diff             @@
##           master   #17548      +/-   ##
==========================================
- Coverage   73.95%   73.95%   -0.01%     
==========================================
  Files         693      693              
  Lines       91721    91721              
==========================================
- Hits        67834    67832       -2     
- Misses      22638    22640       +2     
  Partials     1249     1249              
Flag Coverage Δ
python 83.71% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.94% <0.00%> (-0.16%) ⬇️
sdks/python/apache_beam/transforms/util.py 96.06% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5df315...0005316. Read the comment docs.

@aaltay
Copy link
Member

aaltay commented May 27, 2022

Could this be closed now? Or were you planning to get it merged?

@TheNeuralBit
Copy link
Member Author

This should be merged, I forgot to send it for review.

@TheNeuralBit
Copy link
Member Author

R: @AnandInguva

@aaltay
Copy link
Member

aaltay commented May 28, 2022

LGTM. Please self merge after tests pass.

@TheNeuralBit
Copy link
Member Author

Looks like these test results not showing up in the GitHub UI is a bug:

Both passed so I'll go ahead and merge. Thanks @aaltay!

@TheNeuralBit TheNeuralBit merged commit 8a4093c into apache:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants