Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14059] Delete tags.go #17541

Merged
merged 1 commit into from
May 6, 2022

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented May 4, 2022

In release 2.38 we deprecated tags.go (see #17025). We should now remove it entirely


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 4, 2022

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented May 4, 2022

Can one of the admins verify this patch?

@github-actions github-actions bot added the go label May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #17541 (099ff63) into master (7312377) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17541      +/-   ##
==========================================
+ Coverage   73.83%   73.85%   +0.02%     
==========================================
  Files         691      690       -1     
  Lines       91252    91224      -28     
==========================================
  Hits        67373    67373              
+ Misses      22647    22619      -28     
  Partials     1232     1232              
Flag Coverage Δ
go 50.20% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7312377...099ff63. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

R: @youngoli for final approval

@damccorm
Copy link
Contributor Author

damccorm commented May 4, 2022

@youngoli please don't merge this until after the 2.39 cut

@youngoli youngoli merged commit 39de4b2 into apache:master May 6, 2022
@damccorm damccorm deleted the users/damccorm/removeTags branch June 1, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants