Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8932][Cleanup] Change default PubsubIO client from json to grpc. #10479

Closed

Conversation

dpcollins-google
Copy link
Contributor

@dpcollins-google dpcollins-google commented Dec 29, 2019

Diffbased on #10478

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@dpcollins-google
Copy link
Contributor Author

dpcollins-google commented Dec 29, 2019

+R: @udim

@aaltay
Copy link
Member

aaltay commented Jan 3, 2020

R: @chamikaramj could you find a person to review this PR?

@lukecwik
Copy link
Member

lukecwik commented Jan 3, 2020

Note there is another contributor working on updating grpc from 1.17 to 1.26 in #10438 which may impact this change.

You might want to use the linkage checker to validate the upgrade.

@chamikaramj
Copy link
Contributor

R: @udim

Udi, can you take a look since you are more familiar regarding PubSub.

@udim
Copy link
Member

udim commented Jan 8, 2020

retest this please

@udim
Copy link
Member

udim commented Jan 8, 2020

Looks like this is PR is no. 4 in a chain of PRs (none yet merged). I'll wait for those to be merged before reviewing, so that the diff is smaller.

@udim
Copy link
Member

udim commented Jan 8, 2020

retest this please

@dpcollins-google dpcollins-google force-pushed the change-default branch 3 times, most recently from f1cdb8c to 83d7391 Compare January 9, 2020 22:31
@dpcollins-google dpcollins-google force-pushed the change-default branch 7 times, most recently from 6819bde to b5350ce Compare February 11, 2020 19:57
@dpcollins-google dpcollins-google changed the title Change default PubsubIO client from json to grpc. [BEAM-8932][Cleanup] Change default PubsubIO client from json to grpc. Feb 20, 2020
@stale
Copy link

stale bot commented May 10, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label May 10, 2020
@aaltay
Copy link
Member

aaltay commented May 11, 2020

I believe this PR is still active.

@stale stale bot removed the stale label May 11, 2020
@stale
Copy link

stale bot commented Jul 11, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Jul 11, 2020
@stale
Copy link

stale bot commented Jul 18, 2020

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale bot closed this Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants