Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Go cross-compilation fails with main packages of multiple files #21853

Closed
youngoli opened this issue Jun 14, 2022 · 0 comments
Closed

[Bug]: Go cross-compilation fails with main packages of multiple files #21853

youngoli opened this issue Jun 14, 2022 · 0 comments
Assignees
@youngoli
Labels
bug done & done Issue has been reviewed after it was closed for verification, followups, etc. go P2

Comments

@youngoli
Copy link
Contributor

What happened?

If main is split into multiple files then cross-compilation fails (ex. when running a pipeline on Dataflow and creating a worker binary).

Issue Priority

Priority: 2

Issue Component

Component: sdk-go
youngoli added a commit to youngoli/beam that referenced this issue Jun 14, 2022
@youngoli
[apache#21853] Adjust Go cross-compile to target entire package
35b68a6 
This logic was already being applied in the test case but not the general case. Now it is just applied regardless. Instead of targeting a specific main.go file (ex. "foo/main.go") it will now target an entire directory (ex. "foo/.") and get all the other files needed.
@youngoli youngoli mentioned this issue Jun 14, 2022
Merged
4 tasks
lostluck pushed a commit that referenced this issue Jun 14, 2022
@youngoli
[#21853] Adjust Go cross-compile to target entire package (#21854)
b527ac4 
This logic was already being applied in the test case but not the general case. Now it is just applied regardless. Instead of targeting a specific main.go file (ex. "foo/main.go") it will now target an entire directory (ex. "foo/.") and get all the other files needed.
@damccorm damccorm added go and removed sdk-go labels Jun 16, 2022
bullet03 pushed a commit to akvelon/beam that referenced this issue Jun 20, 2022
@youngoli @bullet03
[apache#21853] Adjust Go cross-compile to target entire package (apac…
270e0ce 
…he#21854)

This logic was already being applied in the test case but not the general case. Now it is just applied regardless. Instead of targeting a specific main.go file (ex. "foo/main.go") it will now target an entire directory (ex. "foo/.") and get all the other files needed.
@youngoli youngoli self-assigned this Jul 14, 2022
@chamikaramj chamikaramj added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youngoli youngoli

Labels
bug done & done Issue has been reviewed after it was closed for verification, followups, etc. go P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@youngoli @chamikaramj @lostluck @damccorm