Skip to content

Commit

Permalink
Also include KafkaIO
Browse files Browse the repository at this point in the history
  • Loading branch information
chamikaramj committed May 6, 2022
1 parent f529e42 commit ecc7a11
Show file tree
Hide file tree
Showing 16 changed files with 39 additions and 27 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@
*
* <h3>Updates to the I/O connector code</h3>
*
* For any updates to this I/O connector, please consider involving corresponding code reviewers
* mentioned
* For any significant updates to this I/O connector, please consider involving corresponding code
* reviewers mentioned
* <a href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
Expand Down
1 change: 0 additions & 1 deletion sdks/java/io/google-cloud-platform/OWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# See the OWNERS docs at https://s.apache.org/beam-owners
# Please involve following reviewers (Github IDs) for code reviews related to respective connectors.

reviewers (BigTableIO) :
- igorbernstein2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,8 @@
*
* <h3>Updates to the I/O connector code</h3>
*
* For any updates to this I/O connector, please consider involving corresponding code reviewers
* mentioned <a
* For any significant updates to this I/O connector, please consider involving corresponding code
* reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@
*
* <h3>Updates to the I/O connector code</h3>
*
* For any updates to this I/O connector, please consider involving corresponding code reviewers
* mentioned <a
* For any significant updates to this I/O connector, please consider involving corresponding code
* reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,8 @@
*
* <h3>Updates to the I/O connector code</h3>
*
* For any updates to this I/O connector, please consider involving corresponding code reviewers
* mentioned
* For any significant updates to this I/O connector, please consider involving corresponding code
* reviewers mentioned
* <a href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@
*
* <h3>Updates to the I/O connector code</h3>
*
* For any updates to this I/O connector, please consider involving corresponding code reviewers
* mentioned <a
* For any significant updates to this I/O connector, please consider involving corresponding code
* reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
*
* <h3>Updates to the I/O connector code</h3>
*
* For any updates to this I/O connector, please consider involving corresponding code reviewers
* mentioned <a
* For any significant updates to this I/O connector, please consider involving corresponding code
* reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,8 @@
*
* <h3>Updates to the I/O connector code</h3>
*
* For any updates to this I/O connector, please consider involving corresponding code reviewers
* mentioned <a
* For any significant significant updates to this I/O connector, please consider involving
* corresponding code reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
Expand Down
7 changes: 7 additions & 0 deletions sdks/java/io/kafka/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs at https://s.apache.org/beam-owners

reviewers:
- aromanenko-dev
- chamikaramj
- lukecwik
- johnjcasey
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,13 @@
* ensure that the version included with the application is compatible with the version of your
* Kafka cluster. Kafka client usually fails to initialize with a clear error message in case of
* incompatibility.
*
* <h3>Updates to the I/O connector code</h3>
*
* For any significant significant updates to this I/O connector, please consider involving
* corresponding code reviewers mentioned <a
* href="https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/OWNERS">
* here</a>.
*/
@Experimental(Kind.SOURCE_SINK)
@SuppressWarnings({
Expand Down
1 change: 0 additions & 1 deletion sdks/python/OWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# See the OWNERS docs at https://s.apache.org/beam-owners
# Please involve following reviewers (Github IDs) for code reviews related to respective connectors.

reviewers (all changes):
- aaltay
Expand Down
4 changes: 2 additions & 2 deletions sdks/python/apache_beam/io/gcp/bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,8 @@ def compute_table_name(row):
**Updates to the I/O connector code**
For any updates to this I/O connector, please consider involving corresponding
code reviewers mentioned in
For any significant updates to this I/O connector, please consider involving
corresponding code reviewers mentioned in
https://github.com/apache/beam/blob/master/sdks/python/OWNERS
"""

Expand Down
4 changes: 2 additions & 2 deletions sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
**Updates to the I/O connector code**
For any updates to this I/O connector, please consider involving corresponding
code reviewers mentioned in
For any significant updates to this I/O connector, please consider involving
corresponding code reviewers mentioned in
https://github.com/apache/beam/blob/master/sdks/python/OWNERS
"""
# pytype: skip-file
Expand Down
6 changes: 3 additions & 3 deletions sdks/python/apache_beam/io/gcp/gcsfilesystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
**Updates to the I/O connector code**
For any updates to this I/O connector, please consider involving corresponding
code reviewers mentioned in
For any significant updates to this I/O connector, please consider involving
corresponding code reviewers mentioned in
https://github.com/apache/beam/blob/master/sdks/python/OWNERS
"""

Expand All @@ -33,7 +33,7 @@
from apache_beam.io.filesystem import CompressionTypes
from apache_beam.io.filesystem import FileMetadata
from apache_beam.io.filesystem import FileSystem
from apache_beam.io.gcp import gcsio
from apache_beam.io.gcp import gcsio<a

__all__ = ['GCSFileSystem']

Expand Down
4 changes: 2 additions & 2 deletions sdks/python/apache_beam/io/gcp/gcsio.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
**Updates to the I/O connector code**
For any updates to this I/O connector, please consider involving corresponding
code reviewers mentioned in
For any significant updates to this I/O connector, please consider involving
corresponding code reviewers mentioned in
https://github.com/apache/beam/blob/master/sdks/python/OWNERS
"""

Expand Down
4 changes: 2 additions & 2 deletions sdks/python/apache_beam/io/gcp/pubsub.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
**Updates to the I/O connector code**
For any updates to this I/O connector, please consider involving corresponding
code reviewers mentioned in
For any significant updates to this I/O connector, please consider involving
corresponding code reviewers mentioned in
https://github.com/apache/beam/blob/master/sdks/python/OWNERS
"""

Expand Down

0 comments on commit ecc7a11

Please sign in to comment.