Move 'update' pipeline option to correct interface

apache · Mar 2, 2016 · 1f31d4d · 1f31d4d
1 parent c9e5525
commit 1f31d4d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineDebugOptions.java b/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineDebugOptions.java
@@ -172,11 +172,15 @@ public Dataflow create(PipelineOptions options) {
 
   /**
    * Whether to update the currently running pipeline with the same name as this one.
+   * 
+   * @deprecated This property is replaced by @{link DataflowPipelineOptions#getUpdate()}
    */
   @JsonIgnore
+  @Deprecated
   @Description("If set, replace the existing pipeline with the name specified by --jobName with "
       + "this pipeline, preserving state.")
   boolean getUpdate();
+  @Deprecated
   void setUpdate(boolean value);
 
   /**

diff --git a/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineOptions.java b/sdk/src/main/java/com/google/cloud/dataflow/sdk/options/DataflowPipelineOptions.java
@@ -91,6 +91,19 @@ public interface DataflowPipelineOptions extends
   String getJobName();
   void setJobName(String value);
 
+  /**
+   * Whether to update the currently running pipeline with the same name as this one.
+   */
+  @Override
+  @SuppressWarnings("deprecation") // base class member deprecated in favor of this one.
+  @Description(
+      "If set, replace the existing pipeline with the name specified by --jobName with "
+          + "this pipeline, preserving state.")
+  boolean getUpdate();
+  @Override
+  @SuppressWarnings("deprecation") // base class member deprecated in favor of this one.
+  void setUpdate(boolean value);
+
   /**
    * Returns a normalized job name constructed from {@link ApplicationNameOptions#getAppName()}, the
    * local system user name (if available), and the current time. The normalization makes sure that