-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39982: [Java] Add RunEndEncodedVector #43888
Conversation
8cab62d
to
2d6eb89
Compare
java/vector/src/main/java/org/apache/arrow/vector/compare/VectorVisitor.java
Outdated
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/types/Types.java
Outdated
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorDataVisitor.java
Outdated
Show resolved
Hide resolved
java/vector/src/test/java/org/apache/arrow/vector/validate/TestValidateVector.java
Outdated
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorVisitor.java
Outdated
Show resolved
Hide resolved
java/vector/src/test/java/org/apache/arrow/vector/TestRunEndEncodedVector.java
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/complex/RunEndEncodedVector.java
Outdated
Show resolved
Hide resolved
*/ | ||
@Override | ||
public void setNull(int index) { | ||
throw new UnsupportedOperationException( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, we could splice the child, but let's ignore that for now
java/vector/src/main/java/org/apache/arrow/vector/complex/RunEndEncodedVector.java
Outdated
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/complex/RunEndEncodedVector.java
Outdated
Show resolved
Hide resolved
Co-authored-by: David Li <li.davidm96@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just one small thing.
@vibhatha do you want to take a look as well?
int rightLogicalIndex = range.getRightStart(); | ||
|
||
while (leftLogicalIndex < leftRangeEnd) { | ||
int leftPhysicalIndex = leftVector.getPhysicalIndex(leftLogicalIndex); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can file a new issue for it and leave a TODO here.
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorBufferVisitor.java
Show resolved
Hide resolved
java/vector/src/test/java/org/apache/arrow/vector/TestRunEndEncodedVector.java
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/complex/RunEndEncodedVector.java
Outdated
Show resolved
Hide resolved
…ndEncodedVector.java
java/vector/src/main/java/org/apache/arrow/vector/complex/RunEndEncodedVector.java
Outdated
Show resolved
Hide resolved
…ndEncodedVector.java
java/c/src/main/java/org/apache/arrow/c/BufferImportTypeVisitor.java
Outdated
Show resolved
Hide resolved
@ViggoC thanks for getting this PR to the finish line. |
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?