GH-41692: [Python] Improve substrait extended expressions support #41693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amol-
commented
Jul 3, 2024
| @@ -56,7 +56,7 @@ Status ParseFromBufferImpl(const Buffer& buf, const std::string& full_name, | |||
| if (message->ParseFromZeroCopyStream(&buf_stream)) { | |||
| return Status::OK(); | |||
| } | |||
| return Status::IOError("ParseFromZeroCopyStream failed for ", full_name); | |||
| return Status::Invalid("ParseFromZeroCopyStream failed for ", full_name); | |||
There was a problem hiding this comment.
It seemed odd that it failed with an IOError given that the ArrayInputStream was built from already in-memory Buffer, so no IO was involved. If it fails, it actually means that the Substrait data is invalid
github-actions
bot
added
awaiting committer review
|
Marking as ready for review as the failures seem to be unrelated, @jorisvandenbossche would you mind reviewing this when you have the chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some missing features and usability issues when using PyArrow with Substrait ExtendedExpressions
BoundExpressionsforScanner(columns=X)instead of a dict of expressions.BoundExpressionsforScanner(filter=X)so that user doesn't have to distinguish betweenExpressionandBoundExpressionsand can always just usepyarrow.substrait.deserialize_expressionspyarrow.BoundExpressionsdirectly fromprotobuf.Message, thus allowing to use substrait-python objects.memoryviewfrom methods encoding substrait, so that those can be directly passed to substrait-python (or more in general other python libraries) without a copy being involved.memoryviewso that the output of encoding functions can be sent back to dencoding functions.