-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38200: [CI][Release][Go] Ensure removing all module caches #38222
Conversation
|
@github-actions crossbow submit verify-rc-source-go-macos-* verify-rc-source-integration-macos-* |
Revision: 78aa946 Submitted crossbow builds: ursacomputing/crossbow @ actions-a0f3d42c00 |
+1 |
### Rationale for this change Module caches don't have write permission by owner. So we can remove them by `rm -rf`. ### What changes are included in this PR? Run `go clean -modcache` after all builds. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #38200 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…pache#38222) ### Rationale for this change Module caches don't have write permission by owner. So we can remove them by `rm -rf`. ### What changes are included in this PR? Run `go clean -modcache` after all builds. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38200 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit bb5ebbf. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…pache#38222) ### Rationale for this change Module caches don't have write permission by owner. So we can remove them by `rm -rf`. ### What changes are included in this PR? Run `go clean -modcache` after all builds. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38200 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…pache#38222) ### Rationale for this change Module caches don't have write permission by owner. So we can remove them by `rm -rf`. ### What changes are included in this PR? Run `go clean -modcache` after all builds. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38200 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…pache#38222) ### Rationale for this change Module caches don't have write permission by owner. So we can remove them by `rm -rf`. ### What changes are included in this PR? Run `go clean -modcache` after all builds. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38200 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
Module caches don't have write permission by owner. So we can remove them by
rm -rf
.What changes are included in this PR?
Run
go clean -modcache
after all builds.Are these changes tested?
Yes.
Are there any user-facing changes?
No.