GH-37510: [C++] Don't install bundled Azure SDK for C++ #38176
Conversation
|
|
github-actions
bot
added
Component: C++
awaiting committer review
kou
force-pushed
the
cpp-azure-sdk-cpp-no-install
branch
from
a68f554
to
3e0df2a
Compare
There was a problem hiding this comment.
With the release imminent and there being a clear workaroudn (system azure sdk) I am ok with this solution.
A future improvement might be installing the sdk into the build tree instead of the host system by modifing:
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} # DLLs (if produced by build) go to "/bin"
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} # static .lib files
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} # .lib files for DLL build
INCLUDES DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
Or setting EXCLUDE_FROM_ALL for each of the azure targets might also work? Not sure if dir scope is needed to supress the installation...
| # EXCLUDE_FROM_ALL is available since CMake 3.28 | ||
| # EXCLUDE_FROM_ALL TRUE |
There was a problem hiding this comment.
iirc you could just leave that there and cmake will ignore it if it doesn't know it
There was a problem hiding this comment.
Unfortunately, CMake reports an error for this case...
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
Does this approach apply a patch to Azure SDK for C++? I want to avoid having a patch...
It will work but I want to maintain target list for Azure SDK for C++... It'll increase maintenance cost like Abseil... |
|
I'll merge this for 14.0.0. |
### Rationale for this change It's an internal bundled library. We should not install it as a part of Arrow. ### What changes are included in this PR? Exclude all Azure SDK for C++ jobs including install jobs aren't executed by default. Building jobs are executed because they are required to build Arrow. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #37510 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…#38176) ### Rationale for this change It's an internal bundled library. We should not install it as a part of Arrow. ### What changes are included in this PR? Exclude all Azure SDK for C++ jobs including install jobs aren't executed by default. Building jobs are executed because they are required to build Arrow. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37510 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 7047e63. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…#38176) ### Rationale for this change It's an internal bundled library. We should not install it as a part of Arrow. ### What changes are included in this PR? Exclude all Azure SDK for C++ jobs including install jobs aren't executed by default. Building jobs are executed because they are required to build Arrow. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37510 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…#38176) ### Rationale for this change It's an internal bundled library. We should not install it as a part of Arrow. ### What changes are included in this PR? Exclude all Azure SDK for C++ jobs including install jobs aren't executed by default. Building jobs are executed because they are required to build Arrow. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37510 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…#38176) ### Rationale for this change It's an internal bundled library. We should not install it as a part of Arrow. ### What changes are included in this PR? Exclude all Azure SDK for C++ jobs including install jobs aren't executed by default. Building jobs are executed because they are required to build Arrow. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37510 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
It's an internal bundled library. We should not install it as a part of Arrow.
What changes are included in this PR?
Exclude all Azure SDK for C++ jobs including install jobs aren't executed by default. Building jobs are executed because they are required to build Arrow.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.