-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FlightRPC][Java] Provide standard way to get client IP address #31924
Comments
It seems like this could be helpful in various situations. Although the gRPC interface for it is considered unstable, it's been around for quite a while and would likely not break unexpectedly (there would be a deprecation and migration path). An easy way to expose this could be creating some sort of |
Hi, I have done some changes about this issue. Before creating a pull request I would like to discuss them here. This is the change: About the experimetal status from the I think it is also useful if the following method receives the new The information about the client ip could be interesting for deciding about the authentication. Updated: The movement on the grpc issue was before the comment of @aiguofer |
This is great! I would love to have something like this. Another nice thing to add to the Side note: I would also love to have the |
…IPaddress Added RequestInfo to Authenticator classes.
I've just added changes for having the Maybe I add tests and create a PR, for checking if they are valid changes for contributing. |
Obtaining the IP address of the client can be accomplished via gRPC, but the gRPC interface exposing this information is considered unstable. It would be good to expose this through a standard interface in Flight, both to buffer any future changes/instability in gRPC, but also in support of alternative transports.
Reporter: Todd Farmer / @toddfarmer
Note: This issue was originally created as ARROW-16565. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: