Relax zstd-sys Version Pin

[waynexia]

Which issue does this PR close?

Closes #.

Rationale for this change

I hit this while trying to upgrade arrow for datafusion.

Parquet depends on zstd-sys and datafusion depends on async-compression which then depends on zstd-sys via zstd-safe.

Parquet cannot use zstd-sys beyond 2.0.9 due to gyscos/zstd-rs#269. And zstd-safe has two available versions 7.0.0 which depends on zstd-sys 2.0.7 and 7.1.0 on zstd-sys 2.10.0.

So to make parquet be compatible with projects use async-compression, the only available version to zstd-sys is 2.0.7

What changes are included in this PR?

Downgrade and pin zstd-sys to 2.0.7

Are there any user-facing changes?

Yes, the dependences

This patch needs to be included in the next release #5688 if possible

[kylebarron]

Maybe <= 2.0.9?

[waynexia]

Maybe <= 2.0.9?

That looks better 👍 Changed in fc4c06a

[Xuanwo]

This could pick up zstd-sys 1.0, please make sure we also have >= 2.0.0.

[waynexia]

Ahh, that works 💯

[Xuanwo]

The same, <0.13.1 here will also pick 0.12, 0.11.

[tustvold]

I'm somewhat inclined to think we should just remove the version pin, and document that people using wasm32 will need to manually pin zstd-sys themselves. We're creating pain for all of our users by pinning this crate, to save some pain for a very small subset of our community... Ultimately if zstd-sys broke support for wasm32 it is on them to fix it

[Xuanwo]

I'm somewhat inclined to think we should just remove the version pin, and document that people using wasm32 will need to manually pin zstd-sys themselves.

I agree that libs like parquet should not pin dependencies. This forces users to adopt the same pinned version, increasing the likelihood of conflicts. Instead of pinning versions downstream, it's better for us to collaborate upstream to address the issue.

[waynexia]

I'm somewhat inclined to think we should just remove the version pin, and document that people using wasm32 will need to manually pin zstd-sys themselves. We're creating pain for all of our users by pinning this crate, to save some pain for a very small subset of our community... Ultimately if zstd-sys broke support for wasm32 it is on them to fix it

That's also an option. Cargo provides patch mechanism to override deps

[tustvold]

Cargo provides patch mechanism to override deps

They shouldn't need to go that far, if they have a lockfile they can just use cargo update --precise, otherwise they can just declare an explicit dependency on zstd-sys and pin it there.

[tustvold]

You will need to update the wasm CI to pin zstd-sys

[tustvold]

I suspect zstd-sys can be removed entirely

[waynexia]

Moved to target-specified deps (for CI)

[waynexia]

Removed them in d7d5e9b based on above discussion

[waynexia]

Thank you all ❤️