Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update arrow-format #5502

Merged
merged 1 commit into from
Mar 15, 2024
Merged

chore: update arrow-format #5502

merged 1 commit into from
Mar 15, 2024

Conversation

ariesdevil
Copy link
Contributor

@ariesdevil ariesdevil commented Mar 13, 2024

Which issue does this PR close?

Part of #5506 .

Rationale for this change

Update arrow-format to new version.

What changes are included in this PR?

Update arrow-format to new version, include ListView, LargeListView, BinaryView and StringView.

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 13, 2024
@ariesdevil ariesdevil force-pushed the parquet branch 2 times, most recently from e33311b to f628c3e Compare March 15, 2024 03:03
@github-actions github-actions bot added the parquet Changes to the parquet crate label Mar 15, 2024
@ariesdevil ariesdevil marked this pull request as ready for review March 15, 2024 03:06
@@ -32,8 +32,7 @@ use arrow_ipc::writer;
use arrow_schema::{DataType, Field, Fields, Schema, TimeUnit};

use crate::basic::{
ConvertedType, LogicalType, Repetition, TimeUnit as ParquetTimeUnit,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file seem unrelated to this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo formatted...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also code changes mixed in though...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

tustvold
tustvold previously approved these changes Mar 15, 2024
@tustvold tustvold dismissed their stale review March 15, 2024 03:15

Need to revert parquet changes

@tustvold tustvold merged commit 78aff9c into apache:master Mar 15, 2024
27 checks passed
@ariesdevil ariesdevil deleted the parquet branch March 15, 2024 06:29
@tustvold tustvold mentioned this pull request Mar 16, 2024
3 tasks
@@ -720,6 +726,33 @@ impl<'a> RecordBatch<'a> {
)
}
}
/// Some types such as Utf8View are represented using a variable number of buffers.
/// For each such Field in the pre-ordered flattened logical schema, there will be
/// an entry in variadicBufferCounts to indicate the number of number of variadic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the number of number of

Redundant words.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants