Retry Safe/Read-Only Requests on Timeout #5278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Jan 3, 2024
| @@ -173,13 +173,16 @@ impl RetryExt for reqwest::RequestBuilder { | |||
| let max_retries = config.max_retries; | |||
| let retry_timeout = config.retry_timeout; | |||
|
|
|||
| let (client, req) = self.build_split(); | |||
| let req = req.expect("request must be valid"); | |||
There was a problem hiding this comment.
Previously this would have panicked try_clone below, so this doesn't change the behaviour. The clients shouldn't be constructing requests that fail validation and so panicking here is the "correct" thing to do.
tustvold
commented
Jan 3, 2024
| @@ -242,7 +245,9 @@ impl RetryExt for reqwest::RequestBuilder { | |||
| Err(e) => | |||
| { | |||
| let mut do_retry = false; | |||
| if let Some(source) = e.source() { | |||
| if req.method().is_safe() && e.is_timeout() { | |||
There was a problem hiding this comment.
Technically we could retry PUT requests as they are idempotent, that is even if repeated they yield the same server-side state, however, in the presence of request preconditions this behaviour I think might be surprising to users even if it is technically correct.
tustvold
changed the title
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This configures automatic retries of timeouts for safe / read-only requests. This not only helps to improve availability, but when combined with a low request timeout can also improve request latencies. In fact AWS recommends doing exactly this here.
What changes are included in this PR?
Are there any user-facing changes?